Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with // @bun annotation in main thread #3855

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

// @bun broke due to async transpiler

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

I wrote automated tests

Checklist

If JavaScript/TypeScript modules or builtins changed:

  • I ran make js and committed the transpiled changes
  • I or my editor ran Prettier on the changed files (or I ran bun fmt)
  • I included a test for the new code, or an existing test covers it

If Zig files changed:

  • I checked the lifetime of memory allocated to verify it's (1) freed and (2) only freed when it should be
  • I or my editor ran zig fmt on the changed files
  • I included a test for the new code, or an existing test covers it
  • JSValue used outside outside of the stack is either wrapped in a JSC.Strong or is JSValueProtect'ed

If new methods, getters, or setters were added to a publicly exposed class:

  • I added TypeScript types for the new methods, getters, or setters

If dependencies in tests changed:

  • I made sure that specific versions of dependencies are used instead of ranged or tagged versions

If functions were added to exports.zig or bindings.zig

  • I ran make headers to regenerate the C header file

If *.classes.ts files were added or changed:

  • I ran make codegen to regenerate the C++ and Zig code

If a new builtin ESM/CJS module was added:

  • I updated Aliases in module_loader.zig to include the new module
  • I added a test that imports the module
  • I added a test that require() the module

@Jarred-Sumner Jarred-Sumner merged commit 3e5beb1 into main Jul 28, 2023
@Jarred-Sumner Jarred-Sumner deleted the jarred/fix-bug-with-@bun branch July 28, 2023 05:30
@github-actions
Copy link
Contributor

@Jarred-Sumner 1 files with test failures on linux-x64:

  • test/js/node/child_process/child_process-node.test.js

View test output

#ba636613fb5dbf6bda30efe6b4db07a5a52a6563

@github-actions
Copy link
Contributor

@Jarred-Sumner 1 files with test failures on linux-x64-baseline:

  • test/js/node/child_process/child_process-node.test.js

View test output

#ba636613fb5dbf6bda30efe6b4db07a5a52a6563

@github-actions
Copy link
Contributor

@Jarred-Sumner 3 files with test failures on bun-darwin-aarch64:

  • test/js/bun/net/socket.test.ts
  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/test/test-test.test.ts

View test output

#ba636613fb5dbf6bda30efe6b4db07a5a52a6563

trnxdev pushed a commit to trnxdev/bun that referenced this pull request Aug 9, 2023
* Uncomment test

* Fix bug with // @Bun + async transpiler

---------

Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant